email me when external ip changes

Question

I'm trying to write a bash script for my server. What this script does is runs curl to get the latest IP address of my box and then email me if it's different from the old IP address stored in a file.

This is what I have now:

#!/bin/bash
#if ip address changes do
x=$(curl -4 "icanhazip.com")
y=$(cat ./oldIP.txt )
if [ "$x"!="$y" ];
    then
    echo "Current IP Address is $x"
    echo "Previous IP address is $y"
#   y=$x
elif [ "$x"="$y"]
    then
    echo "The IP addresses are the same"
fi
#send email to me

I tried using if; then; else; as well however I cannot get the script to react differently when the IP addresses are the same.

I believe the issue stems from my variable declaration for $y.

Answer 1

You must leave spaces between operands within test brackets [ ].

#!/bin/bash
#if ip address changes do
x=$(curl -4 icanhazip.com )
y=$(cat ./oldIP.txt )
if [ "$x" != "$y" ]
    then
    echo "Current IP Address is $x"
    echo "Previous IP address is $y"
#   y=$x
else
    echo "The IP addresses are the same"
fi
#send email to me