ZSH: Read command fails within bash function "read:1: -p: no coprocess"

30

8

Edit:

Seems to work within bash. It appears the problem is related to zsh. If there is a better site to post this issue on let me know.


I am writing a simple script that creates a series of directories. I want the user to give a confirmation before I do so. I'm using the following as a basis, but cannot seem to get it to run within a bash function. If I put it outside of a function it works fine. Here is an isolated example:

read.sh

#!/bin/bash
test() {
  read -p "Here be dragons. Continue?" -n 1 -r
  if [[ $REPLY =~ ^[Yy]$ ]]
  then
    echo "You asked for it..."
  fi
}

code from this SO post.

Sourcing the file and/or test results in the following error: read:1: -p: no coprocess. Same output when I place it in my .bashrc

Edit::

@hennes

  1. I want the function to be in a config file, so I can call it from whatever directory (ideally my .bashrc or .zshrc)
  2. I've corrected the formatting of the first commented line. Problem still exists in zsh
  3. Bash version is 3.2, but you've helped me figure out that the problem is with zsh and not bash.

Nick Tomlin

Posted 2013-02-22T16:59:47.960

Reputation: 527

@NickTomlin Do you know how to make it work without having to put Enter after 'y' (under ZSH)? – syntagma – 2015-04-16T10:27:49.877

@REACHUS alas, I do not. Good luck! – Nick Tomlin – 2015-04-16T13:01:25.823

A little advice. Naming a function 'test' is actually a bad idea... 'test' is actually a shell built-in in both zsh and bash... So your shell will either use the built-in when you try to call your own function, or any scripts run in the same instance after you declare the function will get in trouble (if they rely on the shell built-in)... – svin83 – 2018-10-20T12:33:02.600

>

  • Is there any place where you actually call the function test() ? 2) #! /bin/bash with a space behind she shebang? I thought those were not allowed? 3) '#!/usr/bin/env bash' is probably better. 4) Which bash version? (I tested with bash 4.1.10 on FreeBSD and got no errors)
  • < – Hennes – 2013-02-22T17:05:56.243

    I improperly tagged the question, I'm using zsh but didn't think that there would be conflict with bash scripts (i have several other similar scripts running all right). I've retagged it, and responded to your questions. Thanks for pointing me in the right direction! – Nick Tomlin – 2013-02-22T17:33:06.847

    How do you start the program? The shebang (#!)interpreterline is only needed if you want to execute the file with./read.sh. It is not needed it you run it in any other way or if you put it in an startup script. And if you want to run it in zsh withzsh ./read.sh' then the lines starting with a # get ignored. They also confuse since their give the impression that you use bash when you use zsh). – Hennes – 2013-02-22T20:48:30.637

    Answers

    52

    The –p option doesn’t mean the same thing to bash’s read built-in command and zsh’s read built-in command.  In zsh’s read command, –p means –– guess –– “Input is read from the coprocess.”  I suggest that you display your prompt with echo or printf.

    You may also need to replace –n 1 with –k or –k 1.


    The zsh equivalent of bash's read -p prompt is

    read "?Here be dragons. Continue?"
    

    Anything after a ? in the first argument is used as the prompt string.

    And of course you can specify a variable name to read into (and this may be better style):

    read "brave?Here be dragons. Continue?"
    if [[ "$brave" =~ ^[Yy]$ ]]
    then
        ...
    fi
    

    (Quoting shell variables is generally a good idea, too.)

    Scott

    Posted 2013-02-22T16:59:47.960

    Reputation: 17 653

    Great explanation, thank's! Had the exact same problem – iosifv – 2019-01-25T13:25:23.137

    Thanks for the explanation of why this is not functioning properly. I will check for differences like this in the future. – Nick Tomlin – 2013-02-22T22:04:44.017

    8

    This code seems to do what you want in zsh.
    (Note that the question you refered to explicitly mentions it is for bash).

    #!/usr/bin/env zsh
    
    test()
    {
      echo -n "Here be dragons. Continue?"
      read REPLY
    
      if [[ $REPLY =~ ^[Yy]$ ]]
      then
        echo "You asked for it..."
      fi
    }
    
    test
    

    Three comments:

    Hennes

    Posted 2013-02-22T16:59:47.960

    Reputation: 60 739

    On the last line of this function you should add REPLY="" to clear the REPLY variable. Otherwise if you echo $REPLY you will see it is still set until you open or close your terminal or set it again. – jasonleonhard – 2019-09-26T16:48:06.327

    Thank you for your help. I've given the answer to @scott because of the explanation of why this is not functioning, but the snippet you've given me works perfectly. – Nick Tomlin – 2013-02-22T22:05:33.280

    1Just three more things: This was probably best asked on SO (as it is a programming question). 2) Not all shells are compatible (man zsh returns different stuff for read -p then man bash does. 3) Another solution would be to searchj for vared -c -p 'prompt question' – Hennes – 2013-02-22T22:10:00.440

    +1 Thanks for letting me know. I'll direct future programming-centric questions to SO. – Nick Tomlin – 2013-02-22T22:31:50.320

    0

    This version allows you to have more than one case y or Y, n or N

    1. Optionally: Repeat the question until an approve question is provided

    2. Optionally: Ignore any other answer

    3. Optionally: Exit the terminal if you want

      confirm() {
          echo -n "Continue? y or n? "
          read REPLY
          case $REPLY in
          [Yy]) echo 'yup y' ;; # you can change what you do here for instance
          [Nn]) echo 'nope n' ;;
          # Here are a few optional options to choose between
          # Any other answer:
      
          # 1. Repeat the question
          *) confirm ;;
      
          # 2. ignore
          # *) ;;
      
          # 3. Exit terminal
          # *) exit ;;
      
          esac
          # REPLY=''
      }
      

    Notice this too: On the last line of this function clear the REPLY variable. Otherwise if you echo $REPLY you will see it is still set until you open or close your terminal or set it again.

    jasonleonhard

    Posted 2013-02-22T16:59:47.960

    Reputation: 117